Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change measureName to show path so remove works #232

Merged
merged 1 commit into from
May 17, 2021

Conversation

bryantaustin13
Copy link
Contributor

Measure refresh reporting list to console was erroneously measures failing that were actually refreshing
Description

Changed the code so that it uses the path to the measure for successfully refreshing measures so they will not be in failed list when complete.

  • Github Issue:
  • [x ] I've read the contribution guidelines
  • [ x] Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

@bryantaustin13 bryantaustin13 requested review from brynrhodes and sliver007 and removed request for brynrhodes May 17, 2021 20:08
Copy link
Collaborator

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and resolves the issue locally.

@sliver007 sliver007 merged commit bacab42 into master May 17, 2021
@JPercival JPercival deleted the refreshMeasureFailFix branch May 24, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants